-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not found title text doesn't animate when keyboard is closed (iOS) #36999
Fix not found title text doesn't animate when keyboard is closed (iOS) #36999
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.44-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
Details
The not found has a title and subtitle text. The title position doesn't animate when the page is resized when a keyboard is shown.
Fixed Issues
$ #36411
PROPOSAL: #36411 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Android/iOS/mWeb
only iOS animates the text position movement
Web/Desktop
No keyboard
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-21.at.14.57.55.mov
Android: mWeb Chrome
Screen.Recording.2024-02-21.at.14.56.12.mov
iOS: Native
Screen.Recording.2024-02-21.at.14.53.24.mov
iOS: mWeb Safari
Screen.Recording.2024-02-21.at.14.58.30.mov
MacOS: Chrome / Safari
MacOS: Desktop